Finalized pending ADRs + security enhancements #1127
Conversation
Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
|
@v0lkan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
| } | ||
|
|
||
| var currentStateLock sync.RWMutex // Protects access to the CurrentState object. |
There was a problem hiding this comment.
having a mutex as a member of struct was raising a go vet warning.
Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
|
@v0lkan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
| 1. Use `go vet` and `govulncheck` | ||
| 2. Use `go vet`, `govulncheck`, and Snyk | ||
| 3. Use `go vet`, `govulncheck`, `codesweep`, and `gosec` | ||
| 4. Use `go vet`, `govulncheck`, Snyk, and `golangci-lint` |
There was a problem hiding this comment.
Thanks for the golangci-lint suggestion @gurkanguray .
|
Since there are code changes too, I'll run it on the build server before merging this. |
Finalized pending ADRs + security enhancements