Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): change VMware, Inc. to VMware secrets manager contributors. #490

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

huseyingulec
Copy link
Contributor

@huseyingulec huseyingulec commented Feb 6, 2024

I have made a very basic change for copyright statements, replaced VMware, Inc. with VMware Secrets Manager contributors.

resolves #487

Signed-off-by: huseyingulec <itshuseyingulec@gmail.com>
@huseyingulec huseyingulec changed the title chore(docs): change VMware, Inc. to VMware secrets manager contributors. resolves #487 chore(docs): change VMware, Inc. to VMware secrets manager contributors. Feb 6, 2024
@v0lkan
Copy link
Contributor

v0lkan commented Feb 6, 2024

@huseyingulec: Thanks for your contribution.

One question though:

There are a lot of formatting changes.

I’m not against them; however, we need to make this repeatable if we do a blanket formatting change.

Are you using some linter?

Can this be automated?

Can it have other styling options?

Signed-off-by: huseyingulec <itshuseyingulec@gmail.com>
Signed-off-by: huseyingulec <itshuseyingulec@gmail.com>
@huseyingulec
Copy link
Contributor Author

I see, my Prettier extension is changed everything :( . It should be fine with new commits.

Copy link
Contributor

@v0lkan v0lkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 .

@v0lkan v0lkan merged commit 4b71421 into vmware-tanzu:main Feb 6, 2024
@v0lkan
Copy link
Contributor

v0lkan commented Feb 6, 2024

Landed!

Thanks @huseyingulec.

@huseyingulec huseyingulec deleted the killVMware branch February 6, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change copyright statements to align with other VMware projects
2 participants