Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

515 unit tests are failing for sentinel logger #522

Conversation

sahinakyol
Copy link
Contributor

#515 unit tests are failing for sentinel logger

Description

Fix tests add env variable for grpc server and client and refactored tests.
It depends to #227 please merge before it!

Changes

List the major changes you have made in bullet points:

-examples/federation-workshop/cluster-1/inspector/Deployment.yaml
-examples/federation-workshop/cluster-2/safe/Deployment.yaml
-examples/multiple-secrets/k8s/Deployment.yaml
-examples/multiple-secrets/k8s/image-override.yaml
-examples/pre-vsecm-workshop/init-container/Deployment.yaml
-examples/pre-vsecm-workshop/inspector/Deployment.yaml
-examples/pre-vsecm-workshop/inspector/image-override.yaml
-examples/pre-vsecm-workshop/sdk/Deployment.yaml
-examples/pre-vsecm-workshop/sidecar/Deployment.yaml
-examples/using-init-container/k8s/Deployment.yaml
-examples/using-sdk/k8s/Deployment.yaml
-examples/using-sidecar/k8s/Deployment.yaml
-examples/vsecm-workshop/workloads/example-init-container/Deployment.yaml
-examples/vsecm-workshop/workloads/inspector/Deployment.yaml
-examples/vsecm-workshop/workloads/keycloak/Deployment.yaml
-helm-charts/0.22.4/charts/safe/values.yaml
-helm-charts/0.22.4/charts/sentinel/values.yaml
-k8s/0.22.4/local/vsecm-distroless-fips.yaml
-k8s/0.22.4/local/vsecm-distroless.yaml
-k8s/0.22.4/local/vsecm-photon-fips.yaml
-k8s/0.22.4/local/vsecm-photon.yaml
-k8s/0.22.4/remote/vsecm-distroless-fips.yaml
-k8s/0.22.4/remote/vsecm-distroless.yaml
-k8s/0.22.4/remote/vsecm-photon-fips.yaml
-k8s/0.22.4/remote/vsecm-photon.yaml
-app/sentinel/logger/logger_port.go
-app/sentinel/logger/logger_test.go

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project’s license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project’s license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

Added log level to sentinel. This similar to safe level which is going to take level number from VSECM_LOG_LEVEL

Signed-off-by: sahinakyol <akyolsahinn@gmail.com>
Remove core dependency

Signed-off-by: sahinakyol <akyolsahinn@gmail.com>
Signed-off-by: sahinakyol <akyolsahinn@gmail.com>
Fix failing tests with env variable set for sentinel logger grpc server and client

Signed-off-by: sahinakyol <akyolsahinn@gmail.com>
Copy link
Contributor

@v0lkan v0lkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 🌮 .

I’ll merge it and run tests in the build server and see how it goes.

Thanks for the contribution 🙏 .

@v0lkan v0lkan merged commit d380806 into vmware-tanzu:main Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants