Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(SPIRE): Bumping spire image with latest release version #566

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

abhishek44sharma
Copy link
Contributor

This is a pull request template. Please provide the following information to
help us review your pull request.

Please remove placeholder text (including this text)and replace it with your
own content.

Title of the Pull Request

Description

Please provide a summary of your changes here. Include the purpose of the change
and any relevant issues this PR addresses.

Changes

List the major changes you have made in bullet points:

  • Change 1
  • Change 2
  • Change 3

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Additional Comments

Include any additional comments or context about the PR here.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project’s license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project’s license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

@vmwclabot
Copy link

@abhishek44sharma, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Copy link
Contributor

@v0lkan v0lkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Assuming it passes tests, we can merge.

I’ll run tests on the build server with the recent main anyway.
(temporarily disabled automation there because I have some manual demo code that I very much would like not stashed and removed every hour :) )

@v0lkan v0lkan merged commit 5a95d1e into main Feb 26, 2024
@v0lkan v0lkan deleted the abhishek/versionBumps branch February 26, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants