Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update quickstart guide in VMware Secrets Manager #746

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

marikann
Copy link
Contributor

@marikann marikann commented Mar 25, 2024

#745

Update quickstart guide and modify deployment in VMware Secrets Manager

Description

This pull request includes updates to the quickstart guide in the VMware Secrets Manager documentation and modifications to the deployment in the using-sdk example. The changes were made in the docs/_pages/0050-quickstart.md and examples/using-sdk/k8s/Deployment.yaml files.

Changes

  • Updated the quickstart guide in VMware Secrets Manager documentation.
  • Modified the deployment in the using-sdk example, specifically the image override images were edited due to issues with the new version.

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Additional Comments

The deployment in the using-sdk example was also edited. The image override images were edited because the new version was not being created correctly.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available under the project's license.

By submitting this pull request, you confirm that my contribution is made under the terms of the project's license and that you have the authority to grant these rights.


Thank you for your contribution to VMware Secrets Manager 🐢⚡️!

Signed-off-by: muhammet.arikan <muhammetarikann@hotmail.com>
Copy link
Contributor

@v0lkan v0lkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🙏.

There are minor changes, yet, I’ll do them after merge

examples/using-sdk/k8s/Deployment.yaml Show resolved Hide resolved
@v0lkan v0lkan merged commit 3b2c3ad into vmware-tanzu:main Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants