Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilization Improvement for the Helm Charts (for Resource-Limited Environments) #933

Merged
merged 16 commits into from
Apr 24, 2024

Conversation

v0lkan
Copy link
Contributor

@v0lkan v0lkan commented Apr 24, 2024

Helm Chart Updates

Description

This PR introduces updates to the helm charts to provide added stability.

Changes

  • Introduced pod priority classes to avoid eviction of critical pods.
  • Introduced health and readiness probes for gradual initialization of the system.
  • Other improvements in the charts.

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project's license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
echo "vsecm-sentinel: deployment available"
kubectl wait --for=condition=Available deployment -n vsecm-system vsecm-safe
kubectl wait --timeout=60s --for=condition=Available deployment -n vsecm-system vsecm-safe
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approximately every 1 out of 20 attempts this was taking slightly larger than 30secs (default) on the build server. 60s should be good enough of a limit.

@@ -0,0 +1,23 @@
# /*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split these to individual files to make it easier to diff/merge with helm-charts-hardened-generated files.

healthProbe:
bindAddress: 127.0.0.1:8083
health:
healthProbeBindAddress: 0.0.0.0:8083
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the 0.0.0.0 binding; I’l take a note to test it with 127.0.0.1 too

- containerPort: 8080
name: healthz

livenessProbe:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are new, and I believe necessary for stability.

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
@v0lkan v0lkan merged commit d7e1387 into main Apr 24, 2024
@v0lkan v0lkan deleted the ovolkan/stabilization2 branch April 24, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant