Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop mappings #134

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Drop mappings #134

merged 1 commit into from
Jul 20, 2021

Conversation

scothis
Copy link
Contributor

@scothis scothis commented May 14, 2021

The functionality enabled by mappings can/will be replaced with
dedicated resources that can decorate a secret exposing the
ProvisionedService duck-type which can be consumed by a ServiceBinding.

Refs servicebinding/spec#154

Signed-off-by: Scott Andrews andrewssc@vmware.com

@vmwclabot vmwclabot added the cla-not-required CLA not required label May 14, 2021
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #134 (8031fe2) into main (a276338) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 8031fe2 differs from pull request most recent head bd56f73. Consider uploading reports for the commit bd56f73 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   92.92%   93.08%   +0.16%     
==========================================
  Files          17       16       -1     
  Lines         622      434     -188     
==========================================
- Hits          578      404     -174     
+ Misses         26       19       -7     
+ Partials       18       11       -7     
Impacted Files Coverage Δ
...is/servicebinding/v1alpha2/servicebinding_types.go 100.00% <ø> (ø)
pkg/reconciler/servicebinding/controller.go 100.00% <ø> (ø)
pkg/reconciler/servicebinding/servicebinding.go 76.66% <100.00%> (-1.30%) ⬇️
...econciler/provisionedservice/provisionedservice.go 75.00% <0.00%> (-5.00%) ⬇️
pkg/resolver/serviceable_resolver.go 92.00% <0.00%> (-0.60%) ⬇️
pkg/apis/labs/v1alpha1/register.go 100.00% <0.00%> (ø)
pkg/apis/labsinternal/v1alpha1/register.go 100.00% <0.00%> (ø)
pkg/apis/servicebinding/v1alpha2/register.go 100.00% <0.00%> (ø)
pkg/apis/labs/v1alpha1/provisionedservice_types.go 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a276338...bd56f73. Read the comment docs.

The functionality enabled by mappings can/will be replaced with
dedicated resources that can decorate a secret exposing the
ProvisionedService duck-type which can be consumed by a ServiceBinding.

Custom type and provider fields are now managed with projected volumes
and field path env vars.

Refs servicebinding/spec#154

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@scothis scothis marked this pull request as ready for review July 20, 2021 03:33
@scothis scothis merged commit 7d04196 into vmware-tanzu:main Jul 20, 2021
@scothis scothis deleted the drop-mappings branch July 20, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required CLA not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants