Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s matrix with k8s v1.24+ #246

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Conversation

rashedkvm
Copy link
Member

@rashedkvm rashedkvm commented Aug 18, 2022

Signed-off-by: Rashed Kamal krashed@vmware.com

Pull request

What this PR does / why we need it

Updates k8s matrix with k8s v1.24+


NOTE Kapp Controller v0.39.0 dropped support for k8s 1.18 and 1.19. We support Carvel packaging for service bindings and removing k8s version 1.18 and 1.19 from the CI test matrix.

@vmwclabot vmwclabot added the cla-not-required CLA not required label Aug 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #246 (39f4167) into main (f8b8a5b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files          16       16           
  Lines         774      774           
=======================================
  Hits          720      720           
  Misses         42       42           
  Partials       12       12           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Rashed Kamal <krashed@vmware.com>
…sed CI requires k8 1.20+

Signed-off-by: Rashed Kamal <krashed@vmware.com>
@rashedkvm rashedkvm requested review from scothis, shashwathi and atmandhol and removed request for scothis August 22, 2022 20:35
@scothis
Copy link
Contributor

scothis commented Aug 22, 2022

Dropping support for a k8s version is a potentially breaking change. Any release containing this change should be >= v0.8.0-0.

Adding support for testing k8s 1.24 does not require dropping support for k8s 1.18/19, although it's reasonable to do so for other reasons.

@atmandhol atmandhol added this to the 0.8.0 milestone Aug 23, 2022
@rashedkvm
Copy link
Member Author

Dropping support for a k8s version is a potentially breaking change. Any release containing this change should be >= v0.8.0-0.

Adding support for testing k8s 1.24 does not require dropping support for k8s 1.18/19, although it's reasonable to do so for other reasons.

Service Bindings implementation is not dropping support for k8s 1.18 or 1.19. You can still install and run Service Bindings on k8s 1.18 and 1.19. If you choose to install Service Bindings using Carvel Package, please ensure to install a compatible version of kapp controller.

@rashedkvm rashedkvm merged commit 10c46bf into vmware-tanzu:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required CLA not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants