Skip to content

Commit

Permalink
Code review feedback
Browse files Browse the repository at this point in the history
Signed-off-by: liz <liz@heptio.com>
  • Loading branch information
liztio committed Jul 11, 2018
1 parent 6f64a20 commit f68fd3b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 7 deletions.
5 changes: 2 additions & 3 deletions cmd/sonobuoy/app/gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,11 @@ func (g *genFlags) Config() (*client.GenConfig, error) {
if err != nil {
if errors.Cause(err) == ErrImageVersionNoClient {
return nil, errors.Wrap(err, kubeError.Error())
} else {
return nil, err
}
return nil, err
}

image = fmt.Sprintf(config.DefaultKubeConformanceImage, imageVersion)
image = config.DefaultKubeConformanceImageURL + ":" + imageVersion
}

return &client.GenConfig{
Expand Down
15 changes: 11 additions & 4 deletions pkg/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,11 @@ import (
const (
// DefaultNamespace is the namespace where the master and plugin workers will run (but not necessarily the pods created by the plugin workers).
DefaultNamespace = "heptio-sonobuoy"
// DefaultKubeConformanceImage is the URL of the docker image to run for the kube conformance tests.
DefaultKubeConformanceImage = "gcr.io/heptio-images/kube-conformance:%s"

// DefaultKubeConformanceImageURL is the URL of the docker image to run for the kube conformance tests.
DefaultKubeConformanceImageURL = "gcr.io/heptio-images/kube-conformance"
// DefaultKubeConformanceImageTag is the default tag of the conformance image
DefaultKubeConformanceImageTag = "latest"
// DefaultAggregationServerBindPort is the default port for the aggregation server to bind to.
DefaultAggregationServerBindPort = 8080
// DefaultAggregationServerBindAddress is the default address for the aggregation server to bind to.
Expand All @@ -43,8 +46,12 @@ const (
MasterResultsPath = "/tmp/sonobuoy"
)

// DefaultImage is the URL of the docker image to run for the aggregator and workers
var DefaultImage = "gcr.io/heptio-images/sonobuoy:" + buildinfo.Version
var (
// DefaultKubeConformanceImage is the URL and tag of the docker image to run for the kube conformance tests.
DefaultKubeConformanceImage = DefaultKubeConformanceImageURL + ":" + DefaultKubeConformanceImageTag
// DefaultImage is the URL of the docker image to run for the aggregator and workers
DefaultImage = "gcr.io/heptio-images/sonobuoy:" + buildinfo.Version
)

///////////////////////////////////////////////////////
// Note: The described resources are a 1:1 match
Expand Down

0 comments on commit f68fd3b

Please sign in to comment.