Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle PodPresets better #473

Closed
chuckha opened this issue Jul 10, 2018 · 1 comment · Fixed by #474
Closed

Handle PodPresets better #473

chuckha opened this issue Jul 10, 2018 · 1 comment · Fixed by #474
Assignees
@timothysc
Labels
area/ux User experience and interface kind/bug Behavior isn't as expected or intended lifecycle/active Actively being worked on p2-moderate

Comments

@chuckha
Copy link
Contributor

chuckha commented Jul 10, 2018

PodPresets are an optional api group that are not enabled by default on a kubeadm cluster.

https://kubernetes.io/docs/concepts/workloads/pods/podpreset/#enable-pod-preset

We have two choices. Remove PodPresets as a resource we harvest or don't print an error if the APIServer doesn't support the resource.
@chuckha chuckha added kind/bug Behavior isn't as expected or intended p2-moderate area/ux User experience and interface labels Jul 10, 2018
@chuckha chuckha added this to the v1.11-upstream sync milestone Jul 10, 2018
@chuckha chuckha self-assigned this Jul 10, 2018
@timothysc
Copy link
Contributor

Yeah I'll remove both PodPresets + Secrets

PodPresets are a weird beast, I'll start working on it.

@timothysc timothysc assigned timothysc and unassigned chuckha Jul 10, 2018
@timothysc timothysc mentioned this issue Jul 10, 2018
Merged
@timothysc timothysc added the lifecycle/active Actively being worked on label Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timothysc timothysc

Labels
area/ux User experience and interface kind/bug Behavior isn't as expected or intended lifecycle/active Actively being worked on p2-moderate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes PodPresets and Secrets gathering timothysc/sonobuoy
2 participants
@chuckha @timothysc