Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes PodPresets and Secrets gathering #474

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

timothysc
Copy link
Contributor

What this PR does / why we need it:
Removes the collection of Secrets due to security constraints
Removes the collection of PodPresets b/c they are a weird opt-in type that are moving out of the main api.

Which issue(s) this PR fixes

Special notes for your reviewer:

Release note:

Removes PodPresets and Secrets gathering

/assign @liztio @chuckha

Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
@timothysc timothysc added this to the v1.11-upstream sync milestone Jul 10, 2018
@timothysc timothysc requested review from chuckha and liztio July 10, 2018 21:58
@timothysc timothysc added the lifecycle/triage Needs reproduction/decisions before advancing label Jul 10, 2018
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timothysc timothysc merged commit 0426731 into vmware-tanzu:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/triage Needs reproduction/decisions before advancing p1-important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle PodPresets better RFE: Remove the ability to collect secrets.
2 participants