Adds commands to print default plugin definitions #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to @zubron I found the tests were failing because of some issue with the sonobuoy gen logic; still to be fixed but |
We have the `sonobuoy gen` command which prints a lot of different types of resources and `sonobuoy gen plugin` which prints custom plugin definitions. Sometimes it would be helpful to be able to print the default e2e or sytemdlogs plugin definitions so that they can be tweaked. Added two commands `sonobuoy gen plugins e2e` and `sonobuoy gen plugins systemd-logs` which does this. Minor tweak to code organization to improve code reuse. Fixes #991 Signed-off-by: John Schnake <jschnake@vmware.com>
zubron
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have the
sonobuoy gencommand which prints a lot ofdifferent types of resources and
sonobuoy gen pluginwhichprints custom plugin definitions. Sometimes it would be helpful
to be able to print the default e2e or sytemdlogs plugin definitions
so that they can be tweaked.
Added two commands
sonobuoy gen plugins e2eandsonobuoy gen plugins systemd-logswhich does this.Minor tweak to code organization to improve code reuse.
Which issue(s) this PR fixes
Fixes #991
Special notes for your reviewer:
These were just printing some data by hitting a code path that was already being used/tested. I didn't add any new tests for this code. Let me know if you want to add some basic one.
Release note: