Refactor image client to not be E2E specific #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubron
force-pushed
the
make-image-client-generic-1028
branch
from
29e694f to
d1ee549
Compare
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
=========================================
+ Coverage 48.16% 49.86% +1.7%
=========================================
Files 78 78
Lines 5633 5613 -20
=========================================
+ Hits 2713 2799 +86
+ Misses 2762 2649 -113
- Partials 158 165 +7
Continue to review full report at Codecov.
|
zubron
force-pushed
the
make-image-client-generic-1028
branch
4 times, most recently
from
0a01f5d to
fcd1f01
Compare
johnSchnake
reviewed
Dec 19, 2019
| AddE2ERegistryConfigFlag(&flags.e2eRegistryConfig, pushCmd.Flags()) | ||
| AddKubeconfigFlag(&flags.kubeconfig, pushCmd.Flags()) | ||
| AddPluginFlag(&flags.plugin, pushCmd.Flags()) | ||
| // TODO(bridget): This won't be required when dealing with other plugins |
There was a problem hiding this comment.
Lets make a follow up issue for this
The existing client for handling plugin images assumed that the images were for the e2e plugin. We are trying to add support for other images so we need to make the image client more generic. This change refactors the image client to deal with image names rather than the internal Kubernetes image `Config` type. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
zubron
force-pushed
the
make-image-client-generic-1028
branch
from
fcd1f01 to
9520411
Compare
johnSchnake
reviewed
Dec 19, 2019
| @@ -89,12 +89,12 @@ func NewRegistryList(repoConfig, k8sVersion string) (*RegistryList, error) { | |||
|
|
|||
| fileContent, err := ioutil.ReadFile(repoConfig) | |||
| if err != nil { | |||
| panic(fmt.Errorf("Error reading '%v' file contents: %v", repoConfig, err)) | |||
| return nil, fmt.Errorf("Error reading '%v' file contents: %v", repoConfig, err) | |||
johnSchnake
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The existing client for handling plugin images assumed that the images
were for the e2e plugin. We are trying to add support for other images
so we need to make the image client more generic. This change refactors
the image client to deal with image names rather than the internal
Kubernetes image
Configtype.Signed-off-by: Bridget McErlean bmcerlean@vmware.com
Which issue(s) this PR fixes
Special notes for your reviewer:
Creating this as a Draft PR for now to check coverage/tests