Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds namespace labels to Cluster resources when creating and deleting #1060

Merged
merged 2 commits into from
Dec 30, 2019

Conversation

danielfbm
Copy link
Contributor

@danielfbm danielfbm commented Dec 20, 2019

What this PR does / why we need it:

When running in parallel delete will remove all cluster resources. This PR will add a label using the same namespace and make sure that one run will not affect another

Which issue(s) this PR fixes
None reported

Special notes for your reviewer:
Will squash commits if PR is accepted.

Release note:

Adds namespace labels to Cluster resource when creating and deleting data allowing parallel runs

…ry ones

Signed-off-by: Daniel Morinigo <danielfbm@gmail.com>
@codecov-io
Copy link

codecov-io commented Dec 20, 2019

Codecov Report

Merging #1060 into master will decrease coverage by 1.94%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
- Coverage    49.9%   47.95%   -1.95%     
==========================================
  Files          78       78              
  Lines        5613     5632      +19     
==========================================
- Hits         2801     2701     -100     
- Misses       2647     2771     +124     
+ Partials      165      160       -5
Impacted Files Coverage Δ
pkg/client/delete.go 4.34% <0%> (-0.24%) ⬇️
pkg/image/v1.17.go 0% <0%> (-100%) ⬇️
pkg/image/manifest.go 39.28% <0%> (-29.61%) ⬇️
cmd/sonobuoy/app/images.go 25.13% <0%> (-6.89%) ⬇️
pkg/plugin/aggregation/aggregator.go 72.67% <0%> (-3.11%) ⬇️
cmd/sonobuoy/app/gen.go 74.1% <0%> (-0.37%) ⬇️
cmd/sonobuoy/app/args.go 90.28% <0%> (-0.27%) ⬇️
pkg/client/interfaces.go 80.95% <0%> (ø) ⬆️
pkg/config/config.go 61.29% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b256d...51791ed. Read the comment docs.

@johnSchnake johnSchnake self-requested a review December 30, 2019 21:01
@johnSchnake
Copy link
Contributor

Thanks for the contribution; I'm certain this will help a bunch of folks. I know that it is common to run multiple copies in different namespaces. 👍

@johnSchnake johnSchnake merged commit 627fa31 into vmware-tanzu:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants