Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update goreleaser to remove deprecated field #1065

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Update goreleaser to remove deprecated field #1065

merged 1 commit into from
Jan 7, 2020

Conversation

johnSchnake
Copy link
Contributor

goreleaser/goreleaser@8defb77#diff-6bc8131dff9242f298c3811fada0c174L180-L196 removed the archive field and it needs updated for the release.

@johnSchnake
Update goreleaser to remove deprecated field
b8f1523 
goreleaser/goreleaser@8defb77#diff-6bc8131dff9242f298c3811fada0c174L180-L196 removed the archive field and it needs updated for the release.
Signed-off-by: John Schnake <jschnake@vmware.com>
@johnSchnake
Copy link
Contributor Author

We should consider adding a step in our build which, even when not on master, will try and use goreleaser with --skip-publish so we can check things like this more frequently.

@johnSchnake
Copy link
Contributor Author

Locally I can run goreleaser release --skip-publish --skip-validate locally where I was otherwise able to repro this issue. Going to go ahead and merge this.

@johnSchnake johnSchnake merged commit efb9d68 into vmware-tanzu:master Jan 7, 2020
@johnSchnake johnSchnake deleted the updateGoReleaserArchiveField branch January 7, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zubron zubron Awaiting requested review from zubron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnSchnake