Decouple building binaries from images #1078
Conversation
johnSchnake
changed the title
|
Comparison of master vs new build flow: 12:51 time to run on master: https://app.circleci.com/github/johnSchnake/sonobuoy/pipelines/524f2171-3763-4b92-a60c-f833bd0c2816/workflows/406651f0-26cf-4703-abe5-552bd64fb4e3 9:10 time to run on this branch: https://app.circleci.com/github/johnSchnake/sonobuoy/pipelines/29d5474c-dc00-4eff-8600-5a4b1ce5713e/workflows/b4acdb26-5344-4505-b71c-ef47fb1c6cc4 Confirmed artifacts still created for the integration tests as expected (wanted to make sure it wasn't really doing a noop or erroring out silently). |
|
|
| @@ -119,7 +119,7 @@ build_container: | |||
| -f $(DOCKERFILE) \ | |||
| . | |||
|
|
|||
| container: sonobuoy | |||
| containers: build/linux/arm64/sonobuoy build/linux/amd64/sonobuoy | |||
There was a problem hiding this comment.
I can't leave a comment on all the lines that need to be updated, but the following targets need to have their dependencies updated to use containers:
alldeploy_kindpush
As a precursor to supporting Windows builds, I'm separating out more parts of our build in CircleCI. Major changes: - unit tests in parallel with other build steps - separate building the binaries, building the images, and running integration tests - using workspaces to persist binaries/images across jobs Total time to run the workflow decreased by about 3m (30%) since the unit tests were no longer on the critical path. Signed-off-by: John Schnake <jschnake@vmware.com>
As a precursor to supporting Windows builds, I'm separating out
more parts of our build in CircleCI.
Major changes:
integration tests
Total time to run the workflow decreased by about 3m (30%) since
the unit tests were no longer on the critical path.