Fix 1.13 resource-consumer image tag #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix! Unsure how we got that wrong but you seem to be correct; even the 1.13.12 patch is using the 1.4 version. If you can rebase and amend your commit with the |
Signed-off-by: Matthew Wong <mattwon@amazon.com>
wongma7
force-pushed
the
resource-consumer113
branch
from
1d193b8
to
9201412
Compare
|
done, ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: 1.13 e2e tests need resource-consumer:1.4, not resource-consumer:1.5. https://github.com/kubernetes/kubernetes/blob/release-1.13/test/utils/image/manifest.go#L131
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: