Add kubernetes-version flag to images subcommands #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubron
approved these changes
Mar 16, 2020
If the cluster the user wants to get images for is not available at the time (preparing images ahead of time, for a coworker, etc) then the user needs a way to specify the version rather than relying on the autodetection. This change also causes the images from `sonobuoy images` to be printed in a sorted order for consistency. Fixes #1082 Signed-off-by: John Schnake <jschnake@vmware.com>
|
Thanks for taking this on 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If the cluster the user wants to get images for is not available
at the time (preparing images ahead of time, for a coworker, etc)
then the user needs a way to specify the version rather than relying
on the autodetection.
This change also causes the images from
sonobuoy imagesto be printedin a sorted order for consistency.
Which issue(s) this PR fixes
Fixes #1082
Special notes for your reviewer:
Release note: