Persist images for all targets #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the Sonobuoy images, we build images for multiple targets. We push them in a separate step from where they were built so they need to be persisted to the workspace. We were previously only persisting the sonobuoy/sonobuoy tagged images, not the sonobuoy/sonobuoy-ARCH images. This was causing CI failures as the image pushing step was trying to push images for different architectures that did not exist locally. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
[When building the Sonobuoy images, we build images for multiple targets.
We push them in a separate step from where they were built so they need
to be persisted to the workspace. We were previously only persisting the
sonobuoy/sonobuoy tagged images, not the sonobuoy/sonobuoy-ARCH images.
This was causing CI failures as the image pushing step was trying to
push images for different architectures that did not exist locally.
Signed-off-by: Bridget McErlean bmcerlean@vmware.com