Use passed VERSION when generating image manifest #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling the `push_manifest` target, we were passing `VERSION` to use for the image tag, however it wasn't being used. Instead we using the `IMAGE_VERSION` which was defined outside the target and was the tag for an image that hadn't been pushed. This modifies the `gen_manifest` target to use the passed `VERSION` value. This also updates our Makefile to get the latest version of manifest-tool. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When calling the
push_manifesttarget, we were passingVERSIONtouse for the image tag, however it wasn't being used. Instead we using
the
IMAGE_VERSIONwhich was defined outside the target and was the tagfor an image that hadn't been pushed. This modifies the
gen_manifesttarget to use the passed
VERSIONvalue.This also updates our Makefile to get the latest version of
manifest-tool.
Signed-off-by: Bridget McErlean bmcerlean@vmware.com