Include custom status in results report #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubron
changed the title
zubron
force-pushed
the
calculate-total-separately
branch
from
cb24c8d to
431abb7
Compare
Previously, results would only be included in the total number of result items if the status for that result was one of the built-in result statuses (passed, failed, skipped, etc). With the addition of manual results reporting, if a user used other custom statuses, these would not be included in the default `results` output and it would look like Sonobuoy had processed no results. This commit modifies the logic for the default `results` output to count all items, not just those which match the built-in statuses. Custom statuses with their count are also included in the output. The overall counts for the built-in statuses are still included as before, but now we also iterate over all other statuses and include them in the output. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
zubron
force-pushed
the
calculate-total-separately
branch
from
431abb7 to
e896008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously, results would only be included in the total number of result
items if the status for that result was one of the built-in result
statuses (passed, failed, skipped, etc). With the addition of manual
results reporting, if a user used other custom statuses, these would not
be included in the default
resultsoutput and it would look likeSonobuoy had processed no results.
This commit modifies the logic for the default
resultsoutput to countall items, not just those which match the built-in statuses. Custom
statuses with their count are also included in the output. The overall
counts for the built-in statuses are still included as before, but now
we also iterate over all other statuses and include them in the output.
Signed-off-by: Bridget McErlean bmcerlean@vmware.com
Release note: