Fix formatting on docs pages #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubron
force-pushed
the
fix-formatting-of-config-docs
branch
3 times, most recently
from
5a4bff7 to
ac26e99
Compare
zubron
force-pushed
the
fix-formatting-of-config-docs
branch
7 times, most recently
from
8334960 to
4a9c804
Compare
This fixes some of the formatting on the Sonobuoy config and Release docs pages. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
zubron
force-pushed
the
fix-formatting-of-config-docs
branch
from
4a9c804 to
83d59f2
Compare
zubron
changed the title
zubron
commented
Aug 24, 2020
| For example, to get logs from two specified namespaces `FieldSelectors = ["metadata.namespace=default","metadata.namespace=heptio-sonobuoy"]` | ||
| * Each field selector contains one or more chained operators, with AND logic | ||
| For example, to get logs from a specified pod `FieldSelectors = ["metadata.namespace=default,metadata.name=pod1"]` | ||
| * Each field selector follows the same format as a [Kubernetes Field Selector][fieldselector]. |
There was a problem hiding this comment.
I opted to link to the Kubernetes docs here which show some examples of field selectors rather than just mentioning the package path.
|
Comparing the two changed pages: Config page before: https://sonobuoy.io/docs/v0.18.4/sonobuoy-config/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some of the formatting on the Sonobuoy config and Release
docs pages.
Signed-off-by: Bridget McErlean bmcerlean@vmware.com