Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update args.go #1127

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Update args.go #1127

merged 2 commits into from
Aug 17, 2020

Conversation

jayunit100
Copy link
Contributor

add unit to --wait description.

What this PR does / why we need it:

fixes missing default units for one of the cmd line help options

Which issue(s) this PR fixes

Special notes for your reviewer:
minor patch so didnt make an issue.

Release note:

release-note

Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The commit needs to be signed-off before merging so once you update that, I will get this merged :)

cmd/sonobuoy/app/args.go Outdated Show resolved Hide resolved
jayunit100 and others added 2 commits August 17, 2020 11:34
add unit to --wait description.

Signed-off-by: jay vyas <jvyas@vmware.com>
Co-authored-by: Bridget McErlean <bridgetmcerlean@gmail.com>
Signed-off-by: jay vyas <jvyas@vmware.com>
@jayunit100
Copy link
Contributor Author

okidoki done thanks

@zubron zubron merged commit 086e048 into vmware-tanzu:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants