Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to k8s.io/* to v0.17.7 and tidy deps #1135

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

vijaykatam
Copy link
Contributor

Bumped k8s.io/api, k8s.io/apimachinery and k8s.io/client-go to v0.17.7 followed by
running go tidy to clean up deps.

Signed-off-by: Vijay Katam vkatam@vmware.com

What this PR does / why we need it:
This PR pins k8s.io/api, k8s.io/apimachinery and k8s.io/client-go to latest patch version of v0.17.x to allow
compatibility with a version of sigs.k8s.io/controller-runtime in a downstream component that wants to use
sonobuoy along with cluster-api which depends on controller-runtime.

Which issue(s) this PR fixes

Special notes for your reviewer:
Ran tests and my downstream dep compiles with the following:

go 1.14

require (
	github.com/mholt/archiver/v3 v3.3.0
	github.com/vmware-tanzu/sonobuoy v0.18.2
	k8s.io/api v0.18.2
	k8s.io/apimachinery v0.18.2
	k8s.io/client-go v0.18.2
	sigs.k8s.io/cluster-api v0.3.6
	sigs.k8s.io/controller-runtime v0.5.3
)
replace (
	github.com/vmware-tanzu/sonobuoy => github.com/vijaykatam/sonobuoy v1.11.5-prerelease.1.0.20200626183722-bf486581a73a
	k8s.io/api => k8s.io/api v0.17.7
	k8s.io/apimachinery => k8s.io/apimachinery v0.17.7
	k8s.io/client-go => k8s.io/client-go v0.17.7

)

Release note:

release-note: N/A as no user facing changes

Bumped k8s.io/api, k8s.io/apimachinery and k8s.io/client-go to v0.17.7 followed by
running go tidy to clean up deps.

Signed-off-by: Vijay Katam <vkatam@vmware.com>
Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vijaykatam. I'm happy to bump the version, but I'm curious - is the downstream project only compatible if we use v0.17.* or could we use the latest version (v0.18.*)? The Sonobuoy codebase would need updating to use v0.18.* but I'm trying to understand if the choice of 0.17.* was due to a restriction for the downstream project or the fact that the Sonobuoy codebase would need modifications.

@zubron zubron merged commit 81fa9a7 into vmware-tanzu:master Jun 30, 2020
@vijaykatam
Copy link
Contributor Author

Hi @zubron, sonobuoy codebase would need changes to use v0.18.*

@zubron
Copy link
Contributor

zubron commented Jun 30, 2020

Thanks, @vijaykatam! That's good to know. I just wanted to check that there wasn't a hard dependency on Sonobuoy needing to use v0.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible dependencies when trying to using sonobuoy along with cluster-api
2 participants