Upgrade Kubernetes client libraries to 0.18.5 #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubron
commented
Jul 6, 2020
| @@ -42,7 +42,7 @@ const ( | |||
| waitOutputFlag = "wait-output" | |||
| customRegistryFlag = "custom-registry" | |||
| kubeconfig = "kubeconfig" | |||
| context = "context" | |||
| kubecontext = "context" | |||
There was a problem hiding this comment.
Modified to avoid clash with imported context package in run.go.
zubron
force-pushed
the
upgrade-k8s-client-libraries-to-0.18.5
branch
from
9d4c8f5 to
8ef2fd9
Compare
This changes upgrades the version the Kubernetes libraries we are using to the latest version, 0.18.5. With this, a number of the APIs had changed to take a `context.Context` parameter. As most of the API uses do not have a surrounding context, these updated calls take a `TODO` context as recommended in the Golang context documentation: https://golang.org/pkg/context/#TODO Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
zubron
force-pushed
the
upgrade-k8s-client-libraries-to-0.18.5
branch
from
8ef2fd9 to
3117f9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This changes upgrades the version the Kubernetes libraries we are using
to the latest version, 0.18.5. With this, a number of the APIs had
changed to take a
context.Contextparameter. As most of the API usesdo not have a surrounding context, these updated calls take a
TODOcontext as recommended in the Golang context documentation:
https://golang.org/pkg/context/#TODO
Signed-off-by: Bridget McErlean bmcerlean@vmware.com