Replace MasterURL with AggregatorURL in WorkerConfig #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We renamed the `master` command to `aggregator` in vmware-tanzu#847 (released in v0.15.3). However, we left some of the existing uses in place to prevent backwards incompatibility. This change renames the `MasterURL` field in `WorkerConfig` to `AggregatorURL` in keeping with our terminology elsewhere. Worker containers are configured using environment variables. This change renames the environment variable but also adds some compatibility for the original environment variable to still be processed. It is possible for different image versions to be used for the aggregator and the worker (although it would have to be explicitly set in the generated manifest). This changes allows older versions of Sonobuoy to be used as the aggregator image but does not allow older versions to be used as the worker image. Although some compatibility is broken, this seems acceptable as we don't recommend mixing versions of images within a single sonobuoy run. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
zubron
force-pushed
the
rename-master-to-aggregator-worker-config
branch
from
cbab299
to
f024f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We renamed the
mastercommand toaggregatorin #847 (released inv0.15.3). However, we left some of the existing uses in place to prevent
backwards incompatibility. This change renames the
MasterURLfield inWorkerConfigtoAggregatorURLin keeping with our terminologyelsewhere. Worker containers are configured using environment variables.
This change renames the environment variable but also adds some
compatibility for the original environment variable to still be
processed.
It is possible for different image versions to be used for the
aggregator and the worker (although it would have to be explicitly set
in the generated manifest). This changes allows older versions of
Sonobuoy to be used as the aggregator image but does not allow older
versions to be used as the worker image. Although some compatibility is
broken, this seems acceptable as we don't recommend mixing versions of
images within a single sonobuoy run.
Signed-off-by: Bridget McErlean bmcerlean@vmware.com
Release note: