Remove unused config file handling from worker #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `LoadConfig` function for the worker was configured to be able to load configuration data from a file. However, the necessary viper function to load and read the file was never called. This functionality has not worked since the initial commit and so it doesn't seem necessary. This is now being removed in favour of only configuring the worker via environment variables. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
LoadConfigfunction for the worker was configured to be able toload configuration data from a file. However, the necessary viper
function to load and read the file was never called. This functionality
has not worked since the initial commit and so it doesn't seem
necessary. This is now being removed in favour of only configuring the
worker via environment variables.
Signed-off-by: Bridget McErlean bmcerlean@vmware.com