Add travis support #127
Add travis support #127
Conversation
liztio
force-pushed
the
liz-travis
branch
2 times, most recently
from
ba91358 to
81066cd
Compare
Makefile
Outdated
| @@ -50,22 +50,24 @@ KUBECFG_CMD = $(DOCKER) run \ | |||
| $(KSONNET_BUILD_IMAGE) \ | |||
| kubecfg show -o yaml -V RBAC_ENABLED=$(RBAC_ENABLED) -J $(WORKDIR) -o yaml $< > $@ | |||
|
|
|||
| DOCKER_RUN ?= $(DOCKER) run --rm -v $(DIR):$(BUILDMNT) -w $(BUILDMNT) $(BUILD_IMAGE) /bin/sh -c | |||
There was a problem hiding this comment.
Might want to change the alias name. DOCKER_BUILDER..?
Makefile
Outdated
| .PHONY: all container push clean cbuild test local generate | ||
|
|
||
| all: container | ||
|
|
||
| test: | ||
| $(DOCKER) run --rm -v $(DIR):$(BUILDMNT) -w $(BUILDMNT) $(BUILD_IMAGE) /bin/sh -c '$(TEST)' | ||
| $(DOCKER_RUN) '$(TEST)' |
There was a problem hiding this comment.
want to have the test: cbuild
and you could get rid of the other stage above.
There was a problem hiding this comment.
I don't quite understand this. They are running different commands?
There was a problem hiding this comment.
They are, but you probably shouldn't run the tests if the builds fail.
So making it a dependent target makes sense to me.
.travis.yml
Outdated
| include: | ||
| - stage: test | ||
| script: make test | ||
| - script: make cbuild |
There was a problem hiding this comment.
Is this a separate stage with no name?
There was a problem hiding this comment.
Unnamed stages inherit the previous stage's name, so you can have multiple simultaneous jobs.
Makefile
Outdated
|
|
||
| container: cbuild | ||
| container: test cbuild |
There was a problem hiding this comment.
if you do the test: cbuild change
then this can become container: test
Signed-off-by: liz <liz@heptio.com>
|
@chuckha now to switch the default checks on the repo and setup the webhooks. Also nix a jenkins job! It will make @davecheney smile ;-) |
Add travis support Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
Add travis support Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
Signed-off-by: liz liz@heptio.com
Fixes: #123