Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update working directory to be / by default #132

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

timothysc
Copy link
Contributor

Signed-off-by: Timothy St. Clair timothysc@gmail.com

Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
@chuckha
Copy link
Contributor

chuckha commented Nov 7, 2017

I have tested this change locally and can confirm this is now needed.

This is the old master using 1.8:

$ docker run -it --rm gcr.io/heptio-images/sonobuoy:master /bin/bash
root@d869f3dd616f:/# 

You can see the root is /.

This is the new dockerfile using 1.9:

$ docker run -it --rm gcr.io/heptio-images/sonobuoy:master /bin/ash
/go #

You can see the root is /go.

LGTM.

@timothysc timothysc merged commit b785ebc into vmware-tanzu:master Nov 7, 2017
jhamilton1 pushed a commit to jhamilton1/sonobuoy that referenced this pull request Jun 27, 2018
Update working directory to be / by default
Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
jhamilton1 pushed a commit to jhamilton1/sonobuoy that referenced this pull request Jun 27, 2018
Update working directory to be / by default
Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com

Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants