Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to try latest then previous api versions, for different queries #153

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

timothysc
Copy link
Contributor

Fixes #149

This will cause a fallback to previous api-groups on 1.7, default check is for 1.8

/cc @rosskukulinski

Signed-off-by: Timothy St. Clair timothysc@gmail.com

…rce queries.

Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Something to think about for later might be: why don't we pass a metav1.ListOptions into the queryNonNsResource but we do for queryNsResource? Might be nice to either remove it from one or add it to the other.

@timothysc timothysc merged commit 0c83a13 into vmware-tanzu:master Nov 20, 2017
jhamilton1 pushed a commit to jhamilton1/sonobuoy that referenced this pull request Jun 27, 2018
Updates to try latest then previous api versions, for different queries
Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
jhamilton1 pushed a commit to jhamilton1/sonobuoy that referenced this pull request Jun 27, 2018
Updates to try latest then previous api versions, for different queries
Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com

Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants