fix: break the watch loop when the watch fails #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the goroutine keeps spinning in the endless loop as `ch` gets closed on error and Stop(). Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Oct 19, 2023
PR vmware-tanzu/sonobuoy#1933 got merged and 0.57.0 releases, so update accordingly. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the goroutine keeps spinning in the endless loop as
chgets closed on error and Stop().What this PR does / why we need it:
Fixes the issue with 100% CPU usage after a sonobuoy run.
The problem arises when using sonobuoy as a library, and after a integration test run the process proceeds with other stuff, but this stuck goroutine consumes 100% CPU. If another test run happens, we have 2 goroutines, and so on.
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: