Add GCP provider to Sonobuoy #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liz <liz@heptio.com>
|
Are you kidding me, this is really a requirement for gcp? |
timothysc
reviewed
Mar 8, 2018
| @@ -365,6 +385,23 @@ | |||
| ] | |||
| revision = "e19ae1496984b1c655b8044a65c0300a3c878dd3" | |||
|
|
|||
| [[projects]] | |||
| name = "google.golang.org/appengine" | |||
There was a problem hiding this comment.
This just makes me want to cry.
There was a problem hiding this comment.
we could force everyone to use sonobuoy gen for gcp if you want...
chuckha
approved these changes
Mar 8, 2018
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Signed-off-by: liz <liz@heptio.com> Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Signed-off-by: liz <liz@heptio.com> Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
ceridwen
pushed a commit
to ceridwen/sonobuoy
that referenced
this pull request
Jul 19, 2018
Signed-off-by: liz <liz@heptio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a lot of new lines but I think it's important that we add this