Fix format string type error #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`groups` is not a boolean (`%t`), but a pointer. I think this was meant to print the type (`%T`). Without this change you get the following error when building on Go 1.10: ``` cmd/sonobuoy/app/rbac.go:108: Errorf format %t has arg groups of wrong type *github.com/heptio/sonobuoy/vendor/k8s.io/apimachinery/pkg/apis/meta/v1.APIGroupList ``` Signed-off-by: Dan Miller <dmiller@windmill.engineering>
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
`groups` is not a boolean (`%t`), but a pointer. I think this was meant to print the type (`%T`). Without this change you get the following error when building on Go 1.10: ``` cmd/sonobuoy/app/rbac.go:108: Errorf format %t has arg groups of wrong type *github.com/heptio/sonobuoy/vendor/k8s.io/apimachinery/pkg/apis/meta/v1.APIGroupList ``` Signed-off-by: Dan Miller <dmiller@windmill.engineering> Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
`groups` is not a boolean (`%t`), but a pointer. I think this was meant to print the type (`%T`). Without this change you get the following error when building on Go 1.10: ``` cmd/sonobuoy/app/rbac.go:108: Errorf format %t has arg groups of wrong type *github.com/heptio/sonobuoy/vendor/k8s.io/apimachinery/pkg/apis/meta/v1.APIGroupList ``` Signed-off-by: Dan Miller <dmiller@windmill.engineering> Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
ceridwen
pushed a commit
to ceridwen/sonobuoy
that referenced
this pull request
Jul 19, 2018
`groups` is not a boolean (`%t`), but a pointer. I think this was meant to print the type (`%T`). Without this change you get the following error when building on Go 1.10: ``` cmd/sonobuoy/app/rbac.go:108: Errorf format %t has arg groups of wrong type *github.com/heptio/sonobuoy/vendor/k8s.io/apimachinery/pkg/apis/meta/v1.APIGroupList ``` Signed-off-by: Dan Miller <dmiller@windmill.engineering>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groupsis not a boolean (%t), but a pointer. I think this was meantto print the type (
%T).Without this change you get the following error when running
go vetin Go 1.10:Signed-off-by: Dan Miller dmiller@windmill.engineering