Added new templates. #454
Merged
Added new templates. #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckha
approved these changes
Jul 2, 2018
|
|
||
| - Sonobuoy version: | ||
| - Kubernetes version: (use `kubectl version`): | ||
| - Kubernetes installer & version: |
There was a problem hiding this comment.
maybe this could be: Kubernetes installer & installer version (e.g. kops, kubeadm, kubespray)
|
Oh, @jhamilton1 you will have to sign off your commit with git. Also please squash down to 1 commit to get a nice commit message otherwise we'll squash this side and all the commit messages will be concatenated and end up in one big commit message. Thank you for working on this! |
chuckha
reviewed
Jul 2, 2018
|
Okay, I will get that straightened out. |
|
Okay, @chuckha I squashed down to 1 commit and signed that off. Looks like I am still failing that check though. |
|
@jhamilton1 - nope now you have 5 commits. |
Signed-off-by: Jesse <jesse.hamilton@heptio.com>
jhamilton1
force-pushed
the
jhamilton1-new-templates
branch
from
9a10b45 to
61abe9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR adds standardized bug and feature-enhancement templates. Starting with sonobuoy we will apply these to all repos.
Which issue(s) this PR fixes
N/A
Special notes for your reviewer:
I will start a document to track which repos have been updated with these templates.
Release note:
None