Return a non-zero status code for failed plugins #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vmware-tanzu#404 Signed-off-by: Chuck Ha <chuck@heptio.com>
timothysc
reviewed
Jul 9, 2018
|
|
||
| func exitCode(status *aggregation.Status) int { | ||
| switch status.Status { | ||
| case aggregation.FailedStatus: |
There was a problem hiding this comment.
Why is this not an error on GetStatus?
There was a problem hiding this comment.
because it's not an error getting the status -- the error is on the plugin and is reported through the status.
There was a problem hiding this comment.
k, that name aggregation.FailedStatus is super generic.
Do you have an example of this failure w/exit 1?
What does it look like to the user?
There was a problem hiding this comment.
I don't have an example, but it will look like this (hand crafted output):
test salazar:sonobuoy cha$ sonobuoy status
PLUGIN STATUS COUNT
e2e complete 1
systemd_logs failed 1
Sonobuoy has failed. You can see what happened with `sonobuoy logs`.
test salazar:sonobuoy cha$ echo $?
1
timothysc
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404
Signed-off-by: Chuck Ha chuck@heptio.com
I can't really write a test for this, so it's kind of a best effort deal.
What this PR does / why we need it:
This returns a non-zero exit code for
sonobuoy statuswhen the status is that a plugin has failed.Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: