Supports JSON configs #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonobuoy looks at the extensions of the files the configmap defines and uses a loader implementation to Unmarshal the bytes into a struct. Both YAML and JSON are supported with respective file extensions of .yaml and .json. Signed-off-by: Chuck Ha <chuck@heptio.com>
|
Motivation here is that if we use jsonnet to nicely define the plugin configs, we will end up with a ConfigMap that defines JSON plugin configs instead of the expected YAML. We COULD wrap the YAML in a jsonnet string, but that was rejected in PR #9. This PR adds support for JSON plugin config definitions which unblocks #5. |
|
@kensimon could you review please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sonobuoy looks at the extensions of the files the configmap defines
and uses a loader implementation to Unmarshal the bytes into a struct.
Both YAML and JSON are supported with respective file extensions of .yaml and .json.
Signed-off-by: Chuck Ha chuck@heptio.com