Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 'Enable' vs 'Enabled' for RBAC mode #485

Merged
merged 1 commit into from Jul 13, 2018
Merged

use 'Enable' vs 'Enabled' for RBAC mode #485

merged 1 commit into from Jul 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 12, 2018

The usage information for --rbac is incorrect. It specifies Enable instead of Enabled as the correct argument value. This updates the EnabledRBACMode value from Enabled to Enable to maintain consistency with the Disable and Detect RBAC modes.

@liztio
Copy link
Contributor

liztio commented Jul 13, 2018

Hi @jramos! Thank you so much for your PR.

Could you amend your PR with --sign-off? git commit --amend --sign-off should do it, then force push. That's how Heptio does our contributor agreement.

Signed-off-by: Justin Ramos <justin@gigster.com>
@ghost
Copy link
Author

ghost commented Jul 13, 2018

@liztio -- sure, done.

Copy link
Contributor

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@timothysc timothysc merged commit ddaf085 into vmware-tanzu:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants