Sets version image to use vMajor.Minor b/c we don't match all .Patch releases #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eased version tags. Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
chuckha
approved these changes
Jul 13, 2018
liztio
reviewed
Jul 13, 2018
| // NOTE: Until the kube-conformance container is pushed upstream we can't | ||
| // guarantee alignment with exact versioning see https://github.com/heptio/kube-conformance/issues/25 | ||
| // for more details | ||
| return fmt.Sprintf("v%s.%s", version.Major, version.Minor), nil | ||
| } | ||
| return string(*c), nil | ||
| } |
There was a problem hiding this comment.
Do we want to constrain validateVersion to minor releases too? Or is that fine as is
There was a problem hiding this comment.
It was fine for validation so I didn't change it. Ideally I'd like to move the code back to your original PR in the future if we can push upstream to publish the testing container per release.
liztio
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bug fix on run b/c we don't release *.patch versions
Special notes for your reviewer:
See heptio/kube-conformance#25
Release note:
/assign @chuckha @liztio