Quick fix for an empty config SEGV on nil rest.Config bug #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
|
I'm ok with this as a quick fix I'm starting to think about two sonobuoy clients. one that interacts with stuff locally gen (sometimes) and e2e that do not require a kubeconfig and one that interacts with kubernetes, run, status, also gen, etc. The only other thing I'll suggest is that this go directly in https://github.com/heptio/sonobuoy/blob/master/pkg/dynamic/client.go to return a local-only sonobuoy client. |
chuckha
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a condition where getSonobuoyClient(cfg *rest.Config) can be called with a nil cfg
Which is a normal condition that can occur for offline tarball analysis.
Which issue(s) this PR fixes
Special notes for your reviewer:
none
Release note:
/assign @chuckha
/cc @scottslowe