When inspecting another changeset I found our internal template to be old #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… very old and was suprised it still worked. Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
|
@mauilion @joshrosso @carldanley - I don't recall, is a sonobuoy scan pre-upgrade part of the workflow. If so I may augment this change, to support 1.8 just-in-case. |
|
I looked over instructions and the answer was no. |
liztio
approved these changes
Jul 27, 2018
| @@ -118,41 +117,13 @@ func queryNsResource(ns string, resourceKind string, opts metav1.ListOptions, ku | |||
| case "ConfigMaps": | |||
| return kubeClient.CoreV1().ConfigMaps(ns).List(opts) | |||
| case "ControllerRevisions": | |||
| lst, err := kubeClient.AppsV1().ControllerRevisions(ns).List(opts) | |||
There was a problem hiding this comment.
Getting rid of this feels good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Our internal daemonset templates are really old, and I was surprised it worked.
This partially addresses overlaps with #507 as well.
Special notes for your reviewer:
I need to test this some more to verify.
Release note:
/assign @liztio