Fix linter errors

.github/workflows/tkg_integration_tests.yaml

@@ -290,7 +290,7 @@ jobs:
           fi
           make configure-bom
           make generate-embedproviders
-          E2E_CONFIG=$PWD/pkg/v1/tkg/test/config/aws.yaml hack/tools/bin/ginkgo -nodes=3 -v -trace -tags embedproviders pkg/v1/tkg/test/tkgctl/aws_cc 
+          E2E_CONFIG=$PWD/pkg/v1/tkg/test/config/aws.yaml hack/tools/bin/ginkgo -nodes=3 -v -trace -tags embedproviders pkg/v1/tkg/test/tkgctl/aws_cc
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

pkg/v1/config/clientconfig.go

@@ -759,4 +759,4 @@ func GetCompatibilityFilePath() (string, error) {
 		return defaultCompatImagePath, fmt.Errorf("compatibility file is missing from CLI settings in the client configuration")
 	}
 	return cfg.ClientOptions.CLI.CompatibilityFilePath, nil
-}
+}

pkg/v1/tkg/client/cluster.go

@@ -813,4 +813,4 @@ func (c *TkgClient) ValidateManagementClusterVersionWithCLI(regionalClusterClien
 	}
 
 	return nil
-}
+}

pkg/v1/tkg/client/init.go

@@ -740,4 +740,4 @@ func (c *TkgClient) safelyAddFeatureFlag(featureFlags map[string]string, feature
 		featureFlags = map[string]string{feature: value}
 	}
 	return featureFlags
-}
+}

pkg/v1/tkg/test/cc_setup.md

@@ -0,0 +1,28 @@
+# Setup workload cluster on AWS using the ClusterClass mechanism
+
+- Checkout `cc_aws_integ` branch of `https://github.com/vmware-tanzu/tanzu-framework.git` repo.
+- Run `make build-install-cli-local`. This should build and install the Tanzu CLI on your machine.
+- Update ~/.config/tanzu/tkg/bom/tkg-bom-v1.6.0-zshippable.yaml.
+
+```text
+tanzu-framework-management-packages:
+  - version: v0.21.0-dev-142-g9c114e97
+    images:
+      tanzuFrameworkManagementPackageRepositoryImage:
+        imagePath: management
+        imageRepository: gcr.io/eminent-nation-87317/tkg/test16
+        tag: v0.21.0
+```
+
+- Create a management-cluster on AWS. Currently we only validated the ClusterClass based workflows on AWS. `tanzu management-cluster create --ui`
+- Set kubeconfig/kubeconfig to point to the newly created management cluster.
+- Run this script - `pkg/v1/tkg/test/scripts/cc_hack.sh`.
+- Your management-cluster is now ready for you to create a workload cluster using the cluster class mechanism. Create a workload cluster. `tanzu cluster create workload -f wc_config.yaml -v 6`
+- Contents of the `wc_config.yaml` -
+
+```text
+AWS_REGION: us-east-1
+AWS_SSH_KEY_NAME: <ssh key name setup on your AWS environement>
+```
+
+- You might hit an issue with workload cluster creation and it is a known issue - <https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3399>

pkg/v1/tkg/test/config/aws.yaml

@@ -8,4 +8,4 @@ tkg_config_variables:
   AWS_SECRET_ACCESS_KEY: ""
   AWS_SESSION_TOKEN: ""
 management_cluster_options:
-  plan: dev
+  plan: dev

pkg/v1/tkg/test/config/cc/aws/aws_cc_package_config.yaml

@@ -17,4 +17,4 @@ ENABLE_MHC_WORKER_NODE: true
 ENABLE_MHC_CONTROL_PLANE: true
 MHC_UNKNOWN_STATUS_TIMEOUT: 5m
 MHC_FALSE_STATUS_TIMEOUT: 12m
-NODE_STARTUP_TIMEOUT: 20m
+NODE_STARTUP_TIMEOUT: 20m

pkg/v1/tkg/test/tkgctl/aws_cc/aws_cc_suite_test.go

@@ -7,13 +7,14 @@ package aws_cc
 import (
 	"context"
 	"fmt"
-	"github.com/vmware-tanzu/tanzu-framework/pkg/v1/tkg/test/framework/exec"
 	"os"
 	"path/filepath"
 	"strings"
 	"testing"
 	"time"
 
+	"github.com/vmware-tanzu/tanzu-framework/pkg/v1/tkg/test/framework/exec"
+
 	. "github.com/onsi/ginkgo"
 	"github.com/onsi/ginkgo/config"
 	"github.com/onsi/ginkgo/reporters"

pkg/v1/tkg/tkgctl/init.go

@@ -364,4 +364,4 @@ func logManagementCreationSuccess() {
 	log.Info("  tanzu cluster create [name] -f [file]\n\n")
 	log.Info("\nSome addons might be getting installed! Check their status by running the following:\n\n")
 	log.Info("  kubectl get apps -A\n\n")
-}
+}