Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Always populate kubernetesSpec.{*}.imageRepository fields in TKR_DATA values #4315

Closed
imikushin opened this issue Feb 1, 2023 · 0 comments · Fixed by #4298
Closed

Always populate kubernetesSpec.{*}.imageRepository fields in TKR_DATA values #4315

imikushin opened this issue Feb 1, 2023 · 0 comments · Fixed by #4298
Labels
kind/feature Categorizes issue or PR as related to a new feature needs-triage Indicates an issue or PR needs to be triaged

Comments

@imikushin
Copy link
Contributor

Describe the feature request

imageRepository fields in kubernetesSpec.{etcd,pause,coredns,kube-vip} can be empty. In this case, the clients should be defaulting to kubernetesSpec.imageRepository, BUT: it is not as easy as just having the data already in kubernetesSpec.{*}.imageRepository.

We would allow for simpler ClusterClass JSON patches, if we populate kubernetesSpec.{*}.imageRepository fields in TKR_DATA values.

Describe alternative(s) you've considered

Current situation: ClusterClass authors need to check for empty value and get the value from kubernetesSpec.imageRepository. Sometime they'd forget, and it'd cause of a bug.

Affected product area (please put an X in all that apply)

  • (X) APIs
  • ( ) Addons
  • ( ) CLI
  • ( ) Docs
  • ( ) IAM
  • ( ) Installation
  • ( ) Plugin
  • ( ) Security
  • ( ) Test and Release
  • ( ) User Experience
  • (X) Developer Experience

Additional context

@imikushin imikushin added kind/feature Categorizes issue or PR as related to a new feature needs-triage Indicates an issue or PR needs to be triaged labels Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature needs-triage Indicates an issue or PR needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant