This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 192
Populate all imageRepository fields in TKR_DATA values #4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`imageRepository` fields in `TKR.spec.kubernetes.{etcd,pause,coredns, kube-vip}` can be empty. In this case, the clients should be defaulting to `TKR.spec.kubernetes.imageRepository`. This change allows to simplify ClusterClass JSON patches doing this: they can now assume imageRepository fields in TKR_DATA values are non-empty and have the correct value. Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #4298 +/- ##
==========================================
- Coverage 49.42% 48.55% -0.88%
==========================================
Files 452 482 +30
Lines 44789 46934 +2145
==========================================
+ Hits 22139 22788 +649
- Misses 20563 22007 +1444
- Partials 2087 2139 +52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hongtaiwang
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
rajathagasthya
approved these changes
Feb 2, 2023
imikushin
added a commit
that referenced
this pull request
Feb 15, 2023
`imageRepository` fields in `TKR.spec.kubernetes.{etcd,pause,coredns, kube-vip}` can be empty. In this case, the clients should be defaulting to `TKR.spec.kubernetes.imageRepository`. This change allows to simplify ClusterClass JSON patches doing this: they can now assume imageRepository fields in TKR_DATA values are non-empty and have the correct value. Signed-off-by: Ivan Mikushin <imikushin@vmware.com> (cherry picked from commit 6cdbd30)
imikushin
added a commit
that referenced
this pull request
Feb 17, 2023
`imageRepository` fields in `TKR.spec.kubernetes.{etcd,pause,coredns, kube-vip}` can be empty. In this case, the clients should be defaulting to `TKR.spec.kubernetes.imageRepository`. This change allows to simplify ClusterClass JSON patches doing this: they can now assume imageRepository fields in TKR_DATA values are non-empty and have the correct value. Signed-off-by: Ivan Mikushin <imikushin@vmware.com> (cherry picked from commit 6cdbd30)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
imageRepository
fields inTKR.spec.kubernetes.{etcd,pause,coredns,kube-vip}
can be empty. In this case, the clients should be defaulting toTKR.spec.kubernetes.imageRepository
.This change allows to simplify ClusterClass JSON patches doing this: they can now assume imageRepository fields in TKR_DATA values are non-empty and have the correct value.
Which issue(s) this PR fixes
Fixes #4315
Describe testing done for PR
Updated unit tests to reflect the described situation.
Release note
Additional information
Special notes for your reviewer