This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Populate all imageRepository fields in TKR_DATA values (#4298) #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`imageRepository` fields in `TKR.spec.kubernetes.{etcd,pause,coredns,
kube-vip}` can be empty. In this case, the clients should be defaulting
to `TKR.spec.kubernetes.imageRepository`.
This change allows to simplify ClusterClass JSON patches doing this:
they can now assume imageRepository fields in TKR_DATA values are
non-empty and have the correct value.
Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
(cherry picked from commit 6cdbd30)
miclettej
approved these changes
Feb 15, 2023
Codecov Report
@@ Coverage Diff @@
## release-0.28 #4396 +/- ##
===============================================
Coverage ? 48.72%
===============================================
Files ? 482
Lines ? 47102
Branches ? 0
===============================================
Hits ? 22949
Misses ? 21981
Partials ? 2172 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imageRepositoryfields inTKR.spec.kubernetes.{etcd,pause,coredns, kube-vip}can be empty. In this case, the clients should be defaulting toTKR.spec.kubernetes.imageRepository.This change allows to simplify ClusterClass JSON patches doing this: they can now assume imageRepository fields in TKR_DATA values are non-empty and have the correct value.
Signed-off-by: Ivan Mikushin imikushin@vmware.com
(cherry picked from commit 6cdbd30)
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer