Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Extend AWS CloudFormation commands #1054

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Extend AWS CloudFormation commands #1054

merged 1 commit into from
Nov 9, 2021

Conversation

randomvariable
Copy link
Contributor

Adds support for enabling TMC integration using
ENABLE_TMC_CLOUD_PROVIDER_PERMISSIONS=true

as well as adding the generate-cloudformation-template
subcommand to management-cluster permissions aws, which
will allow users to apply CloudFormation by themselves,
or convert the template into IAM policies or Terraform.

Signed-off-by: Naadir Jeewa jeewan@vmware.com

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #937

Describe testing done for PR

Tested locally in my AWS account

Release note

Adds support for enabling TMC integration using ENABLE_TMC_CLOUD_PROVIDER_PERMISSIONS=true
as well as adding the generate-cloudformation-template subcommand to `management-cluster permissions aws`, which
will allow users to apply CloudFormation by themselves, or convert the template into IAM policies or Terraform.

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@randomvariable randomvariable requested review from prkalle and a team as code owners November 3, 2021 19:21
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1054/20211103193049/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1054/20211103193901/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable randomvariable force-pushed the aws-iam-permissions-2 branch 2 times, most recently from 62808a3 to 1bad2f2 Compare November 3, 2021 20:23
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1054/20211103203031/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1054/20211103203541/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable
Copy link
Contributor Author

Error: No space left on device

Oops

@randomvariable
Copy link
Contributor Author

Failing linter tests fixed in #1055

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1054/20211104010028/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable randomvariable requested a review from a team as a code owner November 8, 2021 15:24
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1054/20211108153214/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1054/20211108153830/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@vuil vuil added kind/bug PR/Issue related to a bug area/lcm Related to Cluster Lifecycle management ok-to-merge PRs should be labelled with this before merging labels Nov 8, 2021
@vuil vuil self-assigned this Nov 8, 2021
vuil
vuil approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@randomvariable randomvariable added kind/feature Categorizes issue or PR as related to a new feature and removed kind/bug PR/Issue related to a bug labels Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1054/20211108181022/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable
Extend AWS CloudFormation commands
a45473d 
Adds support for enabling TMC integration using
ENABLE_TMC_CLOUD_PROVIDER_PERMISSIONS=true

as well as adding the generate-cloudformation-template
subcommand to `management-cluster permissions aws`, which
will allow users to apply CloudFormation by themselves,
or convert the template into IAM policies or Terraform.

Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1054/20211109021614/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1054/20211109021951/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable randomvariable merged commit deb083b into vmware-tanzu:main Nov 9, 2021
@randomvariable randomvariable deleted the aws-iam-permissions-2 branch November 9, 2021 03:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vuil vuil vuil approved these changes

@prkalle prkalle Awaiting requested review from prkalle

Assignees

@vuil vuil

Labels
area/lcm Related to Cluster Lifecycle management cla-not-required kind/feature Categorizes issue or PR as related to a new feature ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Tanzu Mission Control's required AWS IAM permissions
3 participants
@randomvariable @vuil @vmwclabot