-
Notifications
You must be signed in to change notification settings - Fork 192
Add cert-manager templates to providers #1162
Conversation
Cluster Generation A/B Results: |
Cluster Generation A/B Results: |
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the addition of pkg/v1/tkg/fakes/providers/providers.zip
file intentional? Is it getting used for unit tests?
Otherwise LGTM
@anujc25 Yes, that was intentional. I modified it for the sake of unit tests. Thanks |
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments! Just one small detail and it's good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you!
Cluster Generation A/B Results: |
Cluster Generation A/B Results: |
Cluster Generation A/B Results: |
What this PR does / why we need it
In CAPI v1.0.0, it moved away from relying on a packaged version of cert-manager manifests during management cluster creation. Instead it is pulling the cert-manager manifest from github. This change ensures that CAPI uses the cert-manager manifests packaged along with the providers instead of pulling from github.
Which issue(s) this PR fixes
Fixes #1114
Describe testing done for PR
~/config/tanzu/tkg
directory and successfully created a management cluster. Made sure that the cert-manager image is being pulled from the tkg registry.Release note
PR Checklist
Additional information
Special notes for your reviewer