Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Fix vsphere cluster ytt template multi cluster issue #1218

Conversation

HanFa
Copy link
Contributor

@HanFa HanFa commented Nov 22, 2021

Signed-off-by: Fang Han fhan@vmware.com

Contributor: @XudongLiuHarold Xudong Liu xudongl@vmware.com

What this PR does / why we need it

Duplicate PR of #1217, fix this issue with fork.

This PR fixes when using AVI to provide control plane VIP, vsphere cluster ytt template multi overlay error.

The bug was introduced by this PR: #1108

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Downstream e2e tests running.

Release note


PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@HanFa HanFa requested a review from a team as a code owner November 22, 2021 06:57
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1218/20211122071339/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@HanFa HanFa force-pushed the topic/xudongl/fix-vsphere-cluster-multi-overlay-issue branch from 82312d4 to 8561c0d Compare November 22, 2021 23:03
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1218/20211122231646/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Contributor

@lubronzhan lubronzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@anujc25 anujc25 added kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging area/cli labels Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli cla-not-required kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants