This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
air-gap script should support customized tkg-bom tag #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZihanJiang96, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@ZihanJiang96 can you please check this link for CLA requirements? https://cla.vmware.com/employee |
|
@ZihanJiang96, VMware has approved your signed contributor license agreement. |
anujc25
added
area/docs
ok-to-merge
|
please merge :) Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
the current airgap script only downloads the tkg-bom image whose tag is equal to the tanzu-cli's version. we need a new way (a new env var
TKG_BOM_IMAGE_TAG) to specify the tkg-bom tag we want to download and migrate.since we added some new tanzu-cli related packages to the tkg-bom, the airgap script needs to use the correct
imgpkg copyflag to migrate them.