Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

add missing ordering annotation to cliplugins CRD in core-management-plugins package #1389

Merged

Conversation

yharish991
Copy link
Member

@yharish991 yharish991 commented Dec 15, 2021

Signed-off-by: Harish Yayi yharish991@gmail.com

What this PR does / why we need it

This PR adds a missing ordering annotation to the cliplugins CRD in core-management-plugins package
This annotation was removed accidentally by this commit 5e6211b

Which issue(s) this PR fixes

Fixes #1388

Describe testing done for PR

Generated the management package repo bundle and created the PackageRepository and PackageInstall CR to test the installation of core-management-plugins package

Release note

Added missing ordering annotation to cliplugins CRD in the core-management-plugins package

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@yharish991 yharish991 added the kind/bug PR/Issue related to a bug label Dec 15, 2021
@yharish991 yharish991 requested a review from a team as a code owner December 15, 2021 21:06
Signed-off-by: Harish Yayi <yharish991@gmail.com>
@yharish991 yharish991 force-pushed the fixCoreManagementPluginAnnotation branch from 0d4ec59 to dad337b Compare December 15, 2021 21:08
@yharish991 yharish991 changed the title add missing ordering annotation to plugins CRD in core-management-plugins package add missing ordering annotation to cliplugins CRD in core-management-plugins package Dec 15, 2021
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing this.

@anujc25 anujc25 added the ok-to-merge PRs should be labelled with this before merging label Dec 15, 2021
@yharish991 yharish991 merged commit 2b23a06 into vmware-tanzu:main Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ordering annotation in cliplugins CRD in core-management-plugins package
3 participants