Bump Go version to 1.17

[rajathagasthya]

What this PR does / why we need it

Bumps Go version to 1.17.

Which issue(s) this PR fixes

Related #857

Describe testing done for PR

$ make lint
$ go test ./...
$ make build-install-cli-all

Release note

Tanzu framwork now uses Go 1.17 for all builds and language feature support.

PR Checklist

• Squash the commits into one or a small number of logical commits
  
• Use good commit messages
• Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

[stmcginnis]

Hmm, I hope this isn't something we're going to start hitting in our GitHub Actions regularly:

Error: No space left on device

[github-actions]

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1446/20220104155314/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

[github-actions]

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1446/20220104155353/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

[github-actions]

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1446/20220104183328/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

[github-actions]

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1446/20220104192215/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

[stmcginnis]

Looks great to me. We should probably get some more feedback on the timing of moving to 1.17 though. My opinion: 1.17 has been out long enough now and has improvements that I think it would be good to make the bump.

[vuil]

lgtm. I second the bump as well. I had to build some targets in cluster-api main and it plain didn't work until I switched to 1.17.

[vijaykatam]

Do we need to bump base golang images in Dockerfiles as well?

[stmcginnis]

I do see a few other places where 1.16 is referenced. I haven't looked closely to see if these all require updating.

• docs/cli/getting-started.md
• docs/release/release-notes-gathering-process.md
• addons/Dockerfile
• pkg/v1/tkr/Dockerfile
• addons/pinniped/post-deploy/Dockerfile
• pkg/v1/sdk/capabilities/Dockerfile
• pkg/v1/sdk/features/Dockerfile
• pkg/v1/builder/template/plugintemplates/gomod.tmpl
• pkg/v1/builder/template/plugintemplates/github_workflow_release.yaml.tmpl
• pkg/v1/builder/template/plugintemplates/gitlab-ci.yaml.tmpl

[rajathagasthya]

@stmcginnis I changed most of the files listed in your previous comment. The ones I didn't change were plugintemplates files. It refers to an old version of tanzu-framework, which I tried to update along with changing Go version to 1.17. But it doesn't seem to like it:

go list -m: github.com/vmware-tanzu/tanzu-framework@v0.14.0 requires
	sigs.k8s.io/cluster-api/test@v1.0.1 requires
	sigs.k8s.io/cluster-api@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000

I think this commit fixes it, but we will need to merge this PR first and then reference it in plugintemplates/gomod.tmpl. I will do it as a follow-up.

[github-actions]

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1446/20220107174614/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

[github-actions]

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1446/20220107193829/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

[stmcginnis]

Do we want to get any other folks giving explicit feedback? I think this is ready to go, but don't want to merge it if there are any other key stakeholders that should weigh in first.

[rajathagasthya]

@vuil I will leave it to you to add the ok-to-merge label. I think this is ready to go.

[stmcginnis]

Maybe a good argument for updating go versions, even if we're not super specific on the bugfix version: https://nvd.nist.gov/vuln/detail/CVE-2021-44716

[vuil]

Done.
May be a good idea to add a release note that stuff is built with 1.17 after the change